cc @ValarDragon @alexanderbez @daniel-farina

btw, you can try and see it yourself here

Codecov Report

Merging #1348 (039404e) into main (f56fbe5) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1348      +/-   ##
==========================================
- Coverage   19.82%   19.79%   -0.03%     
==========================================
  Files         202      202              
  Lines       27685    27725      +40     
==========================================
  Hits         5489     5489              
- Misses      21175    21215      +40     
  Partials     1021     1021              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c7ea07...039404e. Read the comment docs.

Hi @jlbit !

Thanks for this template. Everything looks great. I would only like to suggest having another type of issue.

I think it would be useful to have a story/task type of issue to be mainly used by the core team. Feature requests and the suggested template seem to be useful for external contributors. On the other hand, when our team members write up the issues, they are, oftentimes, not requests but well-defined stories or tasks.

In addition, I find having "Acceptance Criteria" extremely useful. These short descriptions help with defining what exactly needs to be fulfilled for a solution to the issue to be accepted. It helps the author of the issue to plan the scope in advance. Moreover, it eases the reviewer's job by letting them go through the checklist and make sure that all "Acceptance Criteria" have been met. I've brought this up with the team, and folks seemed to be happy to try it. Please take a look at the following example of its use: #1332

Let me know what you think

@p0mvn right, the feature requests are from external users, and @daniel-farina pointed out that such requests should be in https://github.com/osmosis-labs/feature-requests/issues rather than the main repo to avoid distraction.

I've updated the PR to have feature_request.md redirecting to https://github.com/osmosis-labs/feature-requests/issues, and greatly simplified bug_reports.md

Thanks for the update @jlbit

My earlier comment about needing a type for a story/task issue still seems to apply. Our team doesn't only create issues for bugs. Most of the time, we create an issue to do a simple task that may or may not require a code change or investigate a problem. The current bug report template wouldn't apply to a large proportion of the issues that our team creates since most of them are not bugs.

Having a story/task type of issue with sections like:

• "Background"
• "Acceptance Criteria"
  would be helpful. Here is an example: https://github.com/osmosis-labs/osmosis/issues/1332

I understand that this issue type would primarily be meant to be used by the team. We could add a note in the description about the purpose of this template.

I'm going to close this for now since there is a more up to date PR with this: #1399

Please let me know if any concerns